]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemu: Fix memory leak in RDMA migration code
authorJiri Denemark <jdenemar@redhat.com>
Tue, 23 Sep 2014 13:22:24 +0000 (15:22 +0200)
committerJiri Denemark <jdenemar@redhat.com>
Tue, 23 Sep 2014 13:23:10 +0000 (15:23 +0200)
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
src/qemu/qemu_migration.c

index 44cb826b92d18a5111904db3543debc853a6ce66..6b38592d1535cba432f6547299bfdc86d5430c34 100644 (file)
@@ -3792,13 +3792,13 @@ static int doNativeMigrate(virQEMUDriverPtr driver,
             virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
                            _("outgoing RDMA migration is not supported "
                              "with this QEMU binary"));
-            return -1;
+            goto cleanup;
         }
         if (!vm->def->mem.hard_limit) {
             virReportError(VIR_ERR_OPERATION_INVALID, "%s",
                            _("cannot start RDMA migration with no memory hard "
                              "limit set"));
-            return -1;
+            goto cleanup;
         }
     }
 
@@ -3819,6 +3819,7 @@ static int doNativeMigrate(virQEMUDriverPtr driver,
     if (spec.destType == MIGRATION_DEST_FD)
         VIR_FORCE_CLOSE(spec.dest.fd.qemu);
 
+ cleanup:
     virURIFree(uribits);
 
     return ret;