]> xenbits.xensource.com Git - people/liuw/libxenctrl-split/libvirt.git/commitdiff
qemu: Resolve Coverity CHECKED_RETURN
authorJohn Ferlan <jferlan@redhat.com>
Wed, 23 Sep 2015 22:13:57 +0000 (18:13 -0400)
committerJohn Ferlan <jferlan@redhat.com>
Thu, 24 Sep 2015 13:53:39 +0000 (09:53 -0400)
Coverity complains that return from virHookCall is not checked in
one place in qemuProcessStop.  Since the comment notes that we cannot
stop the operation even it if fails, just added the ignore_value.

src/qemu/qemu_process.c

index a8a43aca05199ab7d9694f0c78a646b122a38e65..f2586a1832d0cd8f8fcb5e4c52f76ea30a71485e 100644 (file)
@@ -5273,9 +5273,9 @@ void qemuProcessStop(virQEMUDriverPtr driver,
         char *xml = qemuDomainDefFormatXML(driver, vm->def, 0);
 
         /* we can't stop the operation even if the script raised an error */
-        virHookCall(VIR_HOOK_DRIVER_QEMU, vm->def->name,
-                    VIR_HOOK_QEMU_OP_STOPPED, VIR_HOOK_SUBOP_END,
-                    NULL, xml, NULL);
+        ignore_value(virHookCall(VIR_HOOK_DRIVER_QEMU, vm->def->name,
+                                 VIR_HOOK_QEMU_OP_STOPPED, VIR_HOOK_SUBOP_END,
+                                 NULL, xml, NULL));
         VIR_FREE(xml);
     }