]> xenbits.xensource.com Git - qemu-xen.git/commitdiff
meson: fix logic for gnutls check
authorAlyssa Ross <hi@alyssa.is>
Fri, 6 Aug 2021 14:49:47 +0000 (14:49 +0000)
committerPatchew Applier <no-reply@patchew.org>
Fri, 6 Aug 2021 15:36:11 +0000 (15:36 +0000)
The logic before was

if not get_option('gnutls').auto() or have_system

Which is equivalent to

if get_option('gnutls').enabled() or get_option('gnutls').disabled() or have_system

This means that the check for gnutls is performed even if gnutls is
disabled, which means that the build system will insist on having
libtasn1 if gnutls is found, even if gnutls support is disabled.

When gnutls is disabled, the check for gnutls shouldn't be performed,
to ensure that further build system logic (like the check for
libtasn1) doesn't make decisions based on the presence of gnutls,
rather than the gnutls option.

After making this change, I can successfully ./configure --disable-gnutls
on my system with gnutls installed, but not libtasn1.

Signed-off-by: Alyssa Ross <hi@alyssa.is>
Message-Id: <20210806144947.321647-1-hi@alyssa.is>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
meson.build

index af9bbb83dbae6da21d3c6da74498b8c4ee11f62c..b3e7ec0e92da8d333d0c49bbe4aa04618189ea79 100644 (file)
@@ -824,7 +824,7 @@ endif
 
 gnutls = not_found
 gnutls_crypto = not_found
-if not get_option('gnutls').auto() or have_system
+if get_option('gnutls').enabled() or (get_option('gnutls').auto() and have_system)
   # For general TLS support our min gnutls matches
   # that implied by our platform support matrix
   #