sg-report-job-history (nfc): Refactor osstestrevs code

Split this into (1) get the data from the db (2) process it into the
form we want.

This will make it easy to cache (1).

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>

diff --git a/sg-report-job-history b/sg-report-job-history
index 39ebe02427fdec34c748b9c5b6644e7b90278fb0..d5e37bcdbaced8742418fc86cb9739b36ddee7c1 100755 (executable)
--- a/sg-report-job-history
+++ b/sg-report-job-history
@@ -260,14 +260,17 @@ END
        my $hosts = join ", ", map { $r->{Hosts}{$_} // "-" } @hostvarcols;
        my $hosts_colour = report_altchangecolour(\$alt_hosts, $hosts);
        print H "<td $hosts_colour>".encode_entities($hosts)."</td>\n";
+       my %osstestrevs;
        $osstestverq->execute($r->{Flight}{flight});
+       while (my ($harness) = $osstestverq->fetchrow_array()) {
+           $osstestrevs{$harness}++;
+       }
        my $osstestrevs = join ' ',
             map {
-               $_ = $_->{harness};
                s/^([0-9a-f]{12})[0-9a-f]+\b/$1/;
                "<kbd>".encode_entities($_)."</kbd>";
             }
-            @{ $osstestverq->fetchall_arrayref({}) };
+            sort keys %osstestrevs;
        my $osstest_colour = report_altchangecolour(\$alt_osstest, $osstestrevs);
        print H "<td $osstest_colour>$osstestrevs</td>\n";
        foreach my $i (0..$#rev_grid_cols) {