]> xenbits.xensource.com Git - people/tklengyel/xen.git/commitdiff
xen/ELF: Fix ELF32 PRI formatters
authorAndrew Cooper <andrew.cooper3@citrix.com>
Mon, 24 Apr 2023 11:02:19 +0000 (13:02 +0200)
committerJan Beulich <jbeulich@suse.com>
Mon, 24 Apr 2023 11:02:19 +0000 (13:02 +0200)
It is rude to hide width formatting inside a PRI* macro, doubly so when it's
only in one bitness of the macro.

However its fully buggy when all the users use %#"PRI because then it expands
to the common trap of %#08x which does not do what the author intends.

Switch the 32bit ELF PRI formatters to use plain integer PRI's, just like on
the 64bit side already.  No practical change.

Fixes: 7597fabca76e ("livepatch: Include sizes when an mismatch occurs")
Fixes: 380b229634f8 ("xsplice: Implement payload loading")
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Ross Lagerwall <ross.lagerwall@citrix.com>
master commit: cfa2bb82c01f0c656804cedd8f44eb2a99a2b5bc
master date: 2023-04-19 15:55:29 +0100

xen/include/xen/elfstructs.h

index 06e6f87c3d800df44fbc254448b1f95537224971..3124469faeb4f3ee870ec52d2d0bc1ea53136589 100644 (file)
@@ -561,8 +561,8 @@ typedef struct {
 #endif
 
 #if defined(ELFSIZE) && (ELFSIZE == 32)
-#define PRIxElfAddr    "08x"
-#define PRIuElfWord    "8u"
+#define PRIxElfAddr    PRIx32
+#define PRIuElfWord    PRIu32
 
 #define Elf_Ehdr       Elf32_Ehdr
 #define Elf_Phdr       Elf32_Phdr