]> xenbits.xensource.com Git - people/aperard/xen-unstable.git/commitdiff
x86/vPMU: address violations of MISRA C Rule 20.7
authorNicola Vetrini <nicola.vetrini@bugseng.com>
Wed, 3 Apr 2024 07:35:37 +0000 (09:35 +0200)
committerJan Beulich <jbeulich@suse.com>
Wed, 3 Apr 2024 07:35:37 +0000 (09:35 +0200)
MISRA C Rule 20.7 states: "Expressions resulting from the expansion
of macro parameters shall be enclosed in parentheses". Therefore, some
macro definitions should gain additional parentheses to ensure that all
current and future users will be safe with respect to expansions that
can possibly alter the semantics of the passed-in macro parameter.

No functional change.

Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
xen/arch/x86/include/asm/vpmu.h

index f271f28e4a74a990a91dcc2b94851c6b179cc69b..dae9b43dac6e4ffd99d68d97d6dd0739e7c3e9cb 100644 (file)
@@ -23,8 +23,8 @@
 #define MSR_TYPE_ARCH_CTRL          4
 
 /* Start of PMU register bank */
-#define vpmu_reg_pointer(ctxt, offset) ((void *)((uintptr_t)ctxt + \
-                                                 (uintptr_t)ctxt->offset))
+#define vpmu_reg_pointer(ctxt, offset) ((void *)((uintptr_t)(ctxt) + \
+                                                 (uintptr_t)(ctxt)->offset))
 
 /* Arch specific operations shared by all vpmus */
 struct arch_vpmu_ops {