]> xenbits.xensource.com Git - libvirt.git/commitdiff
virDomainObjListAddLocked: Drop useless @cleanup label
authorMichal Privoznik <mprivozn@redhat.com>
Tue, 28 May 2019 13:47:12 +0000 (15:47 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Wed, 5 Jun 2019 09:01:12 +0000 (11:01 +0200)
It's a premature optimization. It's perfectly acceptable for
'error' label to deal with @vm == NULL case.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
src/conf/virdomainobjlist.c

index f5a7ecc4a47f8aabee262b540c0b86e4f5854ed9..d58d25f847b7579892c8fad1eac880e40c982db2 100644 (file)
@@ -332,7 +332,7 @@ virDomainObjListAddLocked(virDomainObjListPtr doms,
         }
 
         if (!(vm = virDomainObjNew(xmlopt)))
-            goto cleanup;
+            goto error;
         vm->def = def;
 
         if (virDomainObjListAddObjLocked(doms, vm) < 0) {
@@ -340,7 +340,7 @@ virDomainObjListAddLocked(virDomainObjListPtr doms,
             goto error;
         }
     }
- cleanup:
+
     return vm;
 
  error: