qemu: saveimage: only steal domXML on success

The comment and the caller assume virQEMUSaveDataNew only steals
domXML on success, but it is copied even on failure.

Also remove the misleading g_steal_pointer call on a local variable.

Reported by coverity.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Erik Skultety <eskultet@redhat.com>

diff --git a/src/qemu/qemu_saveimage.c b/src/qemu/qemu_saveimage.c
index de2d63dd9a74d01c9c391218760443f26dc5ceda..5d542bf9776fd082842f761b135da8b4365961fc 100644 (file)
--- a/src/qemu/qemu_saveimage.c
+++ b/src/qemu/qemu_saveimage.c
@@ -105,8 +105,6 @@ virQEMUSaveDataNew(char *domXML,
 
     data = g_new0(virQEMUSaveData, 1);
 
-    data->xml = g_steal_pointer(&domXML);
-
     if (cookieObj &&
         !(data->cookie = virSaveCookieFormat((virObjectPtr) cookieObj,
                                              virDomainXMLOptionGetSaveCookie(xmlopt))))
@@ -118,6 +116,7 @@ virQEMUSaveDataNew(char *domXML,
     header->was_running = running ? 1 : 0;
     header->compressed = compressed;
 
+    data->xml = domXML;
     return data;
 
  error: