]> xenbits.xensource.com Git - people/royger/xen.git/commitdiff
x86/mm: add defensive return
authorFederico Serafini <federico.serafini@bugseng.com>
Mon, 2 Sep 2024 09:55:16 +0000 (11:55 +0200)
committerJan Beulich <jbeulich@suse.com>
Mon, 2 Sep 2024 09:55:16 +0000 (11:55 +0200)
Add defensive return statement at the end of an unreachable
default case. Other than improve safety, this meets the requirements
to deviate a violation of MISRA C Rule 16.3: "An unconditional `break'
statement shall terminate every switch-clause".

Signed-off-by: Federico Serafini <federico.serafini@bugseng.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
xen/arch/x86/mm.c

index e9c86208b092c5587092dae053c14c624b8a6844..4148c656579a2c4d906b18246f55f73de7bf444d 100644 (file)
@@ -918,6 +918,7 @@ get_page_from_l1e(
                 return 0;
             default:
                 ASSERT_UNREACHABLE();
+                return -EILSEQ;
             }
         }
         else if ( l1f & _PAGE_RW )