Rename virStorageBackendCreateQemuImgCmd

Add FromVol at the end. This function will create the qemu-img
command line from volume definitions and check them.

diff --git a/src/storage/storage_backend.c b/src/storage/storage_backend.c
index 9322571cc9c8a8ec1302faa25a99af82f69ffab4..fdda0dc7d7a721a648f4b6df530913a9031ac8aa 100644 (file)
--- a/src/storage/storage_backend.c
+++ b/src/storage/storage_backend.c
@@ -858,14 +858,17 @@ virStorageBackendCreateQemuImgOpts(char **opts,
     return -1;
 }
 
+/* Create a qemu-img virCommand from the supplied binary path,
+ * volume definitions and imgformat
+ */
 virCommandPtr
-virStorageBackendCreateQemuImgCmd(virConnectPtr conn,
-                                  virStoragePoolObjPtr pool,
-                                  virStorageVolDefPtr vol,
-                                  virStorageVolDefPtr inputvol,
-                                  unsigned int flags,
-                                  const char *create_tool,
-                                  int imgformat)
+virStorageBackendCreateQemuImgCmdFromVol(virConnectPtr conn,
+                                         virStoragePoolObjPtr pool,
+                                         virStorageVolDefPtr vol,
+                                         virStorageVolDefPtr inputvol,
+                                         unsigned int flags,
+                                         const char *create_tool,
+                                         int imgformat)
 {
     virCommandPtr cmd = NULL;
     bool do_encryption = (vol->target.encryption != NULL);
@@ -1094,8 +1097,8 @@ virStorageBackendCreateQemuImg(virConnectPtr conn,
     if (imgformat < 0)
         goto cleanup;
 
-    cmd = virStorageBackendCreateQemuImgCmd(conn, pool, vol, inputvol, flags,
-                                            create_tool, imgformat);
+    cmd = virStorageBackendCreateQemuImgCmdFromVol(conn, pool, vol, inputvol,
+                                                   flags, create_tool, imgformat);
     if (!cmd)
         goto cleanup;
 

diff --git a/src/storage/storage_backend.h b/src/storage/storage_backend.h
index fd2451cf6ab1131b92b5e88b06e1fe2a148c20ac..bb1e8d892a6b28204c695442a1d9b241ba27925a 100644 (file)
--- a/src/storage/storage_backend.h
+++ b/src/storage/storage_backend.h
@@ -192,13 +192,13 @@ char *virStorageBackendStablePath(virStoragePoolObjPtr pool,
                                   bool loop);
 
 virCommandPtr
-virStorageBackendCreateQemuImgCmd(virConnectPtr conn,
-                                  virStoragePoolObjPtr pool,
-                                  virStorageVolDefPtr vol,
-                                  virStorageVolDefPtr inputvol,
-                                  unsigned int flags,
-                                  const char *create_tool,
-                                  int imgformat);
+virStorageBackendCreateQemuImgCmdFromVol(virConnectPtr conn,
+                                         virStoragePoolObjPtr pool,
+                                         virStorageVolDefPtr vol,
+                                         virStorageVolDefPtr inputvol,
+                                         unsigned int flags,
+                                         const char *create_tool,
+                                         int imgformat);
 
 /* ------- virStorageFile backends ------------ */
 typedef struct _virStorageFileBackend virStorageFileBackend;

diff --git a/tests/storagevolxml2argvtest.c b/tests/storagevolxml2argvtest.c
index 696659cb32696cb2add87e4befa55de93a39b6ef..f5f86c829ca28cb0723dc22f321b1fe4f4687750 100644 (file)
--- a/tests/storagevolxml2argvtest.c
+++ b/tests/storagevolxml2argvtest.c
@@ -98,8 +98,9 @@ testCompareXMLToArgvFiles(bool shouldFail,
     testSetVolumeType(vol, pool);
     testSetVolumeType(inputvol, inputpool);
 
-    cmd = virStorageBackendCreateQemuImgCmd(conn, &poolobj, vol, inputvol,
-                                            flags, create_tool, imgformat);
+    cmd = virStorageBackendCreateQemuImgCmdFromVol(conn, &poolobj, vol,
+                                                   inputvol, flags,
+                                                   create_tool, imgformat);
     if (!cmd) {
         if (shouldFail) {
             virResetLastError();