Database locking: Tcl: Use db-execute-array for SELECT in sg-execute-flight

We are going to make it wrong to use db-execute for SELECT statements.

Convert the existing violation site, which uses db-execute, into
db-execute-array (providing a dummy arrayvar).

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
---
v3: Dropped change to become-task which is actually wrong and should
    be db-update-1, anyway.  This will now be fixed in a separate patch.

diff --git a/sg-execute-flight b/sg-execute-flight
index 27fc04cbd26aed1d99ab6b272215797b1130b3e7..14c8cda5083ec8bb0454e38ac526d482f272a850 100755 (executable)
--- a/sg-execute-flight
+++ b/sg-execute-flight
@@ -30,7 +30,7 @@ proc check {} {
 
     jobdb::db-open
 
-    set nqueued [jobdb::db-execute "
+    set nqueued [jobdb::db-execute-array dummy "
         SELECT job FROM jobs j
          WHERE j.flight = $flight
            AND j.status = 'queued'