]> xenbits.xensource.com Git - libvirt.git/commitdiff
src: don't use VIR_FREE on an object allocation
authorDaniel P. Berrangé <berrange@redhat.com>
Tue, 19 May 2020 14:55:55 +0000 (15:55 +0100)
committerDaniel P. Berrangé <berrange@redhat.com>
Wed, 3 Jun 2020 09:20:17 +0000 (10:20 +0100)
Memory allocated using g_object_new must never be released using
VIR_FREE/g_free because g_object_new uses a special allocation
strategy internally.

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
src/rpc/virnettlscontext.c

index 02c17124a1184146ba5a7c0cc15a8da285d16512..a8104cf48464ccbaaf4e91943ed4927731373fe3 100644 (file)
@@ -752,10 +752,7 @@ static virNetTLSContextPtr virNetTLSContextNew(const char *cacert,
  error:
     if (isServer)
         gnutls_dh_params_deinit(ctxt->dhParams);
-    if (ctxt->x509cred)
-        gnutls_certificate_free_credentials(ctxt->x509cred);
-    VIR_FREE(ctxt->priority);
-    VIR_FREE(ctxt);
+    virObjectUnref(ctxt);
     return NULL;
 }