]> xenbits.xensource.com Git - people/vhanquez/xen.git/commitdiff
x86 hvm: Remove the extra IS_PRIV_FOR() checks I added to do_hvm_op().
authorKeir Fraser <keir.fraser@citrix.com>
Wed, 8 Apr 2009 13:44:11 +0000 (14:44 +0100)
committerKeir Fraser <keir.fraser@citrix.com>
Wed, 8 Apr 2009 13:44:11 +0000 (14:44 +0100)
Actually this is already done by rcu_lock_target_domain_by_id(). Oops.

Signed-off-by: Keir Fraser <keir.fraser@citrix.com>
xen-unstable changeset:   19522:f9c8c6b08972
xen-unstable date:        Wed Apr 08 14:43:12 2009 +0100

xen/arch/x86/hvm/hvm.c

index 70de16f89bd5a8d1f22a5cf8d04667b136ff3fd8..312954e2d7a4d8de590e49c6178392b7121752a0 100644 (file)
@@ -2426,10 +2426,6 @@ long do_hvm_op(unsigned long op, XEN_GUEST_HANDLE(void) arg)
         if ( rc != 0 )
             return rc;
 
-        rc = -EPERM;
-        if ( (curr_d != d) && !IS_PRIV_FOR(curr_d, d) )
-            goto param_fail;
-
         rc = -EINVAL;
         if ( !is_hvm_domain(d) )
             goto param_fail;
@@ -2604,10 +2600,6 @@ long do_hvm_op(unsigned long op, XEN_GUEST_HANDLE(void) arg)
         if ( rc != 0 )
             return rc;
 
-        rc = -EPERM;
-        if ( !IS_PRIV_FOR(curr_d, d) )
-            goto param_fail2;
-
         rc = -EINVAL;
         if ( !is_hvm_domain(d) )
             goto param_fail2;
@@ -2646,10 +2638,6 @@ long do_hvm_op(unsigned long op, XEN_GUEST_HANDLE(void) arg)
         if ( rc != 0 )
             return rc;
 
-        rc = -EPERM;
-        if ( !IS_PRIV_FOR(curr_d, d) )
-            goto param_fail3;
-
         rc = -EINVAL;
         if ( !is_hvm_domain(d) )
             goto param_fail3;
@@ -2706,10 +2694,6 @@ long do_hvm_op(unsigned long op, XEN_GUEST_HANDLE(void) arg)
         if ( rc != 0 )
             return rc;
 
-        rc = -EPERM;
-        if ( !IS_PRIV_FOR(curr_d, d) )
-            goto param_fail4;
-
         rc = -EINVAL;
         if ( !is_hvm_domain(d) )
             goto param_fail4;