]> xenbits.xensource.com Git - qemu-xen.git/commitdiff
lsi53c895a: avoid a warning from clang analyzer
authorBlue Swirl <blauwirbel@gmail.com>
Sun, 4 Sep 2011 11:22:31 +0000 (11:22 +0000)
committerBlue Swirl <blauwirbel@gmail.com>
Sat, 10 Sep 2011 14:52:33 +0000 (14:52 +0000)
Avoid this warning from clang analyzer by deleting the variable:
/src/qemu/hw/lsi53c895a.c:895:5: warning: Value stored to 'id' is never read
    id = (current_tag >> 8) & 0xf;

Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
hw/lsi53c895a.c

index 1643a63ee835169ea3d9514ee13db4482bf1166a..ac284e96098143ae22c7c97fa110ecd85e9c54a0 100644 (file)
@@ -883,7 +883,6 @@ static void lsi_do_msgout(LSIState *s)
     int len;
     uint32_t current_tag;
     lsi_request *current_req, *p, *p_next;
-    int id;
 
     if (s->current) {
         current_tag = s->current->tag;
@@ -892,7 +891,6 @@ static void lsi_do_msgout(LSIState *s)
         current_tag = s->select_tag;
         current_req = lsi_find_by_tag(s, current_tag);
     }
-    id = (current_tag >> 8) & 0xf;
 
     DPRINTF("MSG out len=%d\n", s->dbc);
     while (s->dbc) {
@@ -977,9 +975,8 @@ static void lsi_do_msgout(LSIState *s)
                device, but this is currently not implemented (and seems not
                to be really necessary). So let's simply clear all queued
                commands for the current device: */
-            id = current_tag & 0x0000ff00;
             QTAILQ_FOREACH_SAFE(p, &s->queue, next, p_next) {
-                if ((p->tag & 0x0000ff00) == id) {
+                if ((p->tag & 0x0000ff00) == (current_tag & 0x0000ff00)) {
                     scsi_req_cancel(p->req);
                 }
             }