]> xenbits.xensource.com Git - people/aperard/linux-chromebook.git/commitdiff
Revert "HID: magicmouse: Set multi-touch keybits for Magic Mouse"
authorAndrew de los Reyes <adlr@chromium.org>
Tue, 29 Jan 2013 21:45:16 +0000 (13:45 -0800)
committerChromeBot <chrome-bot@google.com>
Tue, 29 Jan 2013 23:27:12 +0000 (15:27 -0800)
The issue is this causes Chrome, I think, to consider this device a
touchpad, but since we're using the mouse stack (for the time being)
it breaks scroll.

BUG=chromium-os:38330
TEST=manually tested that Magic Mouse works as expected

This reverts commit 5c1386506de5237373db16f470d54e8a83afe318.

Signed-off-by: Andrew de los Reyes <adlr@chromium.org>
Change-Id: I56f420039252a9c0b4283f5aa9ad68655c305576
Reviewed-on: https://gerrit.chromium.org/gerrit/42252
Reviewed-by: Benson Leung <bleung@chromium.org>
drivers/hid/hid-magicmouse.c

index 7aa5c7f0b9da9a58bea40b8136c7f78448a2491b..73647266daadc57ecd36a948e50ff6df80aeed21 100644 (file)
@@ -379,16 +379,16 @@ static int magicmouse_setup_input(struct input_dev *input, struct hid_device *hd
                __clear_bit(BTN_RIGHT, input->keybit);
                __clear_bit(BTN_MIDDLE, input->keybit);
                __set_bit(BTN_MOUSE, input->keybit);
+               __set_bit(BTN_TOOL_FINGER, input->keybit);
+               __set_bit(BTN_TOOL_DOUBLETAP, input->keybit);
+               __set_bit(BTN_TOOL_TRIPLETAP, input->keybit);
+               __set_bit(BTN_TOOL_QUADTAP, input->keybit);
+               __set_bit(BTN_TOOL_QUINTTAP, input->keybit);
+               __set_bit(BTN_TOUCH, input->keybit);
+               __set_bit(INPUT_PROP_POINTER, input->propbit);
                __set_bit(INPUT_PROP_BUTTONPAD, input->propbit);
        }
 
-       __set_bit(BTN_TOOL_FINGER, input->keybit);
-       __set_bit(BTN_TOOL_DOUBLETAP, input->keybit);
-       __set_bit(BTN_TOOL_TRIPLETAP, input->keybit);
-       __set_bit(BTN_TOOL_QUADTAP, input->keybit);
-       __set_bit(BTN_TOOL_QUINTTAP, input->keybit);
-       __set_bit(BTN_TOUCH, input->keybit);
-       __set_bit(INPUT_PROP_POINTER, input->propbit);
 
        __set_bit(EV_ABS, input->evbit);