]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemu: erase synchronous block job cancel mentions in comments
authorNikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
Mon, 16 Apr 2018 10:56:14 +0000 (13:56 +0300)
committerNikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
Thu, 17 May 2018 11:04:33 +0000 (14:04 +0300)
Commit [1] dropped support for synchronous block job cancel.
This patch erases remnants from comments.

[1] commit 2350d101 "qemu: Remove support for legacy block jobs"

Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
Reviewed-by: John Ferlan <jferlan@redhat.com>
src/qemu/qemu_driver.c

index 9037818e2ade43c6b228af94eedb80bbdbd00ae6..b6978380708c68e54f34a266476a7098cf7da3e0 100644 (file)
@@ -16827,13 +16827,12 @@ qemuDomainBlockJobAbort(virDomainPtr dom,
     if (save)
         ignore_value(virDomainSaveStatus(driver->xmlopt, cfg->stateDir, vm, driver->caps));
 
-    /* With synchronous block cancel, we must synthesize an event, and
-     * we silently ignore the ABORT_ASYNC flag.  With asynchronous
-     * block cancel, the event will come from qemu and will update the
-     * XML as appropriate, but without the ABORT_ASYNC flag, we must
-     * block to guarantee synchronous operation.  We do the waiting
-     * while still holding the VM job, to prevent newly scheduled
-     * block jobs from confusing us.  */
+    /*
+     * With the ABORT_ASYNC flag we don't need to do anything, the event will
+     * come from qemu and will update the XML as appropriate, but without the
+     * ABORT_ASYNC flag, we must block to guarantee synchronous operation.  We
+     * do the waiting while still holding the VM job, to prevent newly
+     * scheduled block jobs from confusing us. */
     if (!async) {
         qemuDomainDiskPrivatePtr diskPriv = QEMU_DOMAIN_DISK_PRIVATE(disk);
         qemuBlockJobUpdate(vm, QEMU_ASYNC_JOB_NONE, disk, NULL);