]> xenbits.xensource.com Git - people/andrewcoop/xen.git/commitdiff
tools/tests: Fix newly introduced Makefile
authorAnthony PERARD <anthony.perard@vates.tech>
Mon, 14 Apr 2025 14:17:14 +0000 (16:17 +0200)
committerAnthony PERARD <anthony.perard@vates.tech>
Fri, 25 Apr 2025 09:44:03 +0000 (11:44 +0200)
Fix few issue with this new directory:
- clean generated files
- and ignore those generated files
- include the dependency files generated by `gcc`.
- rework prerequisites:
  "test-rangeset.o" also needs the generated files "list.h" and
  "rangeset.h". Technically, both only needs "harness.h" which needs
  the generated headers, but that's a bit simpler and the previous
  point will add the dependency on "harness.h" automatically.

This last point fix an issue where `make` might decide to build
"test-rangeset.o" before the other files are ready.

Fixes: 7bf777b42cad ("tootls/tests: introduce unit tests for rangesets")
Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
Signed-off-by: Anthony PERARD <anthony.perard@vates.tech>
tools/tests/rangeset/.gitignore [new file with mode: 0644]
tools/tests/rangeset/Makefile

diff --git a/tools/tests/rangeset/.gitignore b/tools/tests/rangeset/.gitignore
new file mode 100644 (file)
index 0000000..cdeb778
--- /dev/null
@@ -0,0 +1,4 @@
+/list.h
+/rangeset.c
+/rangeset.h
+/test-rangeset
index 70076eff34beff0a1ae6b7dc7d977bd014ce7c82..3dafcbd0546c1ee69ef19214092ba0c6c5c404d4 100644 (file)
@@ -12,7 +12,7 @@ run: $(TARGET)
 
 .PHONY: clean
 clean:
-       $(RM) -- *.o $(TARGET) $(DEPS_RM)
+       $(RM) -- *.o $(TARGET) $(DEPS_RM) list.h rangeset.h rangeset.c
 
 .PHONY: distclean
 distclean: clean
@@ -32,7 +32,7 @@ rangeset.h: $(XEN_ROOT)/xen/include/xen/rangeset.h
 list.h rangeset.h:
        sed -e '/#include/d' <$< >$@
 
-rangeset.c: $(XEN_ROOT)/xen/common/rangeset.c list.h rangeset.h
+rangeset.c: $(XEN_ROOT)/xen/common/rangeset.c
        # Remove includes and add the test harness header
        sed -e '/#include/d' -e '1s/^/#include "harness.h"/' <$< >$@
 
@@ -42,5 +42,9 @@ CFLAGS += $(CFLAGS_xeninclude)
 
 LDFLAGS += $(APPEND_LDFLAGS)
 
+test-rangeset.o rangeset.o: list.h rangeset.h
+
 test-rangeset: rangeset.o test-rangeset.o
        $(CC) $^ -o $@ $(LDFLAGS)
+
+-include $(DEPS_INCLUDE)