]> xenbits.xensource.com Git - libvirt.git/commitdiff
tests: use virTestCompareToFile in storagepoolcapstest
authorPavel Hrdina <phrdina@redhat.com>
Wed, 6 Mar 2019 18:02:08 +0000 (19:02 +0100)
committerPavel Hrdina <phrdina@redhat.com>
Thu, 7 Mar 2019 11:01:09 +0000 (12:01 +0100)
This will allow to use VIR_TEST_REGENERATE_OUTPUT.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
tests/storagepoolcapstest.c

index d31f50c9576530ed48547a0d6be144d20b240905..c59069ff7c0e5a0810cfd1d37e383c37fca5e6bf 100644 (file)
@@ -57,7 +57,6 @@ test_virStoragePoolCapsFormat(const void *opaque)
     virStoragePoolCapsPtr poolCaps = NULL;
     int ret = -1;
     VIR_AUTOFREE(char *) path = NULL;
-    VIR_AUTOFREE(char *) poolCapsFromFile = NULL;
     VIR_AUTOFREE(char *) poolCapsXML = NULL;
 
 
@@ -68,16 +67,11 @@ test_virStoragePoolCapsFormat(const void *opaque)
                     abs_srcdir, data->filename) < 0)
         goto cleanup;
 
-    if (virFileReadAll(path, 8192, &poolCapsFromFile) < 0)
-        goto cleanup;
-
     if (!(poolCapsXML = virStoragePoolCapsFormat(poolCaps)))
         goto cleanup;
 
-    if (STRNEQ(poolCapsFromFile, poolCapsXML)) {
-        virTestDifference(stderr, poolCapsFromFile, poolCapsXML);
+    if (virTestCompareToFile(poolCapsXML, path) < 0)
         goto cleanup;
-    }
 
     ret = 0;