]> xenbits.xensource.com Git - libvirt.git/commitdiff
util: unlock closeCallbacks if get callbacks for connect fail
authorWang King <king.wang@huawei.com>
Tue, 10 Jan 2017 06:23:49 +0000 (14:23 +0800)
committerJohn Ferlan <jferlan@redhat.com>
Sat, 21 Jan 2017 17:39:52 +0000 (12:39 -0500)
Avoid return with the closeCallbacks locked when get callbacks list for connect fail.

Signed-off-by: Wang King <king.wang@huawei.com>
Signed-off-by: John Ferlan <jferlan@redhat.com>
src/util/virclosecallbacks.c

index 891a92b10dc68cd01d907b6345e632a34da9ba7a..1fa9596b0ed2bfb9fe05ae8f765ce6617d748aab 100644 (file)
@@ -331,8 +331,10 @@ virCloseCallbacksRun(virCloseCallbacksPtr closeCallbacks,
 
     virObjectLock(closeCallbacks);
     list = virCloseCallbacksGetForConn(closeCallbacks, conn);
-    if (!list)
+    if (!list) {
+        virObjectLock(closeCallbacks);
         return;
+    }
 
     for (i = 0; i < list->nentries; i++) {
         char uuidstr[VIR_UUID_STRING_BUFLEN];