]> xenbits.xensource.com Git - people/liuw/libxenctrl-split/libvirt.git/commitdiff
Fix crash on OOM when parsing disk security label
authorDaniel P. Berrange <berrange@redhat.com>
Mon, 23 Sep 2013 13:07:51 +0000 (14:07 +0100)
committerDaniel P. Berrange <berrange@redhat.com>
Tue, 24 Sep 2013 09:51:28 +0000 (10:51 +0100)
If an OOM error occurs in virSecurityDeviceLabelDefParseXML the
cleanup code may free an uninitialized pointer, causing a crash

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
src/conf/domain_conf.c

index 89535790c357cb880e830607b10d5e9fa2a9fbd0..73ae0b0a64b05d5b6d893b0b9b6cc52dd852112b 100644 (file)
@@ -4507,7 +4507,7 @@ virSecurityDeviceLabelDefParseXML(virSecurityDeviceLabelDefPtr **seclabels_rtn,
                                   int nvmSeclabels, xmlXPathContextPtr ctxt,
                                   unsigned int flags)
 {
-    virSecurityDeviceLabelDefPtr *seclabels;
+    virSecurityDeviceLabelDefPtr *seclabels = NULL;
     size_t nseclabels = 0;
     int n;
     size_t i, j;