]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemuDomainAttachHostPciDevice: Fall back to mem balloon if there's no hard_limit
authorMichal Privoznik <mprivozn@redhat.com>
Mon, 26 Aug 2013 14:59:03 +0000 (16:59 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Mon, 26 Aug 2013 15:38:24 +0000 (17:38 +0200)
If there's no hard_limit set and domain uses VFIO we still must lock
the guest memory (prerequisite from qemu). Hence, we should compute
the amount to be locked from max_balloon.

src/qemu/qemu_hotplug.c

index 2ac1fe5deb91b751136ef03931884b39c841d721..5943816c059cb84c177c8496a269cee30c5a7697 100644 (file)
@@ -1143,6 +1143,8 @@ int qemuDomainAttachHostPciDevice(virQEMUDriverPtr driver,
 
     if (hostdev->source.subsys.u.pci.backend
         == VIR_DOMAIN_HOSTDEV_PCI_BACKEND_VFIO) {
+        unsigned long long memKB;
+
         if (!virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_DEVICE_VFIO_PCI)) {
             virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                            _("VFIO PCI device assignment is not "
@@ -1155,8 +1157,9 @@ int qemuDomainAttachHostPciDevice(virQEMUDriverPtr driver,
          * doesn't hurt to "change" the limit to the same value.
          */
         vm->def->hostdevs[vm->def->nhostdevs++] = hostdev;
-        virProcessSetMaxMemLock(vm->pid,
-                                vm->def->mem.hard_limit * 1024);
+        memKB = vm->def->mem.hard_limit ?
+            vm->def->mem.hard_limit : vm->def->mem.max_balloon + 1024 * 1024;
+        virProcessSetMaxMemLock(vm->pid, memKB);
         vm->def->hostdevs[vm->def->nhostdevs--] = NULL;
     }