]> xenbits.xensource.com Git - qemu-upstream-4.6-testing.git/commitdiff
block/vvfat: Plug memory leak in read_directory()
authorMarkus Armbruster <armbru@redhat.com>
Wed, 28 May 2014 09:17:05 +0000 (11:17 +0200)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Tue, 5 Aug 2014 16:41:12 +0000 (11:41 -0500)
Has always been leaky.  Spotted by Coverity.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Benoit Canet <benoit@irqsave.net>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
(cherry picked from commit b122c3b6d020e529b203836efb8f611ece787293)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
block/vvfat.c

index 1978c9ed629dfb84178ba086527e210ab122840c..439a603c2a50514083f529e07fef3153e68cb250 100644 (file)
@@ -787,7 +787,9 @@ static int read_directory(BDRVVVFATState* s, int mapping_index)
            s->current_mapping->path=buffer;
            s->current_mapping->read_only =
                (st.st_mode & (S_IWUSR | S_IWGRP | S_IWOTH)) == 0;
-       }
+        } else {
+            g_free(buffer);
+        }
     }
     closedir(dir);