]> xenbits.xensource.com Git - qemu-xen.git/commitdiff
hw/isa: Use the QOM DEVICE() macro to access DeviceState.qdev
authorPhilippe Mathieu-Daudé <philmd@redhat.com>
Tue, 28 May 2019 16:40:17 +0000 (18:40 +0200)
committerLaurent Vivier <laurent@vivier.eu>
Thu, 6 Jun 2019 09:33:18 +0000 (11:33 +0200)
Rather than looking inside the definition of a DeviceState with
"s->qdev", use the QOM prefered style: "DEVICE(s)".

This patch was generated using the following Coccinelle script:

    // Use DEVICE() macros to access DeviceState.qdev
    @use_device_macro_to_access_qdev@
    expression obj;
    identifier dev;
    @@
    -&obj->dev.qdev
    +DEVICE(obj)

Suggested-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Message-Id: <20190528164020.32250-8-philmd@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
hw/isa/lpc_ich9.c
hw/isa/vt82c686.c

index 031ee9cd933dc2d7f610533a112f2396c31f249f..35d17246e940aceb7153e3bed9a500b848484a45 100644 (file)
@@ -412,7 +412,7 @@ void ich9_lpc_pm_init(PCIDevice *lpc_pci, bool smm_enabled)
                                  true);
     }
 
-    ich9_lpc_reset(&lpc->d.qdev);
+    ich9_lpc_reset(DEVICE(lpc));
 }
 
 /* APM */
index 85d0532dd5b53794c28e569f38725ac18223739c..d46754f61cfb97086dde0f9c09bd8bac918ec7e3 100644 (file)
@@ -369,7 +369,7 @@ static void vt82c686b_pm_realize(PCIDevice *dev, Error **errp)
     pci_conf[0x90] = s->smb_io_base | 1;
     pci_conf[0x91] = s->smb_io_base >> 8;
     pci_conf[0xd2] = 0x90;
-    pm_smbus_init(&s->dev.qdev, &s->smb, false);
+    pm_smbus_init(DEVICE(s), &s->smb, false);
     memory_region_add_subregion(get_system_io(), s->smb_io_base, &s->smb.io);
 
     apm_init(dev, &s->apm, NULL, s);