]> xenbits.xensource.com Git - people/dariof/xen.git/commitdiff
x86: reduce Meltdown band-aid IPI overhead
authorJan Beulich <jbeulich@suse.com>
Wed, 7 Feb 2018 15:31:41 +0000 (16:31 +0100)
committerJan Beulich <jbeulich@suse.com>
Wed, 7 Feb 2018 15:31:41 +0000 (16:31 +0100)
In case we can detect single-threaded guest processes (by checking
whether we can account for all root page table uses locally on the vCPU
that's running), there's no point in issuing a sync IPI upon an L4 entry
update, as no other vCPU of the guest will have that page table loaded.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: George Dunlap <george.dunlap@citrix.com>
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
xen/arch/x86/mm.c

index 531c0b49b9f53789966a6e06e83f2bffb25873a4..35f204369bade4c9358136bcea38253ed4ab70fe 100644 (file)
@@ -3706,8 +3706,18 @@ long do_mmu_update(
                         break;
                     rc = mod_l4_entry(va, l4e_from_intpte(req.val), mfn,
                                       cmd == MMU_PT_UPDATE_PRESERVE_AD, v);
-                    if ( !rc )
-                        sync_guest = this_cpu(root_pgt);
+                    /*
+                     * No need to sync if all uses of the page can be accounted
+                     * to the page lock we hold, its pinned status, and uses on
+                     * this (v)CPU.
+                     */
+                    if ( !rc && this_cpu(root_pgt) &&
+                         ((page->u.inuse.type_info & PGT_count_mask) >
+                          (1 + !!(page->u.inuse.type_info & PGT_pinned) +
+                           (pagetable_get_pfn(curr->arch.guest_table) == mfn) +
+                           (pagetable_get_pfn(curr->arch.guest_table_user) ==
+                            mfn))) )
+                        sync_guest = true;
                     break;
 
                 case PGT_writable_page: