]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemu: validate: Reword error message when CCW addresses are not supported for a machine
authorPeter Krempa <pkrempa@redhat.com>
Tue, 21 Nov 2023 08:42:16 +0000 (09:42 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Thu, 23 Nov 2023 13:29:48 +0000 (14:29 +0100)
Reword the error message to clearly state that the machine type doesn't
support the address type. It doesn't matter which device it's for.

Additionally the alias may be still NULL at the point when the error is
being reported misleading users that they have something wrong with a
specific device.

Resolves: https://issues.redhat.com/browse/RHEL-16878
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Boris Fiuczynski <fiuczy@linux.ibm.com>
src/qemu/qemu_validate.c

index 93df9e4c8eca497c5363fb7d8b5b91ff31926085..2afd7e128a2f451a9082895eca2b191b0604cdfa 100644 (file)
@@ -1512,8 +1512,8 @@ qemuValidateDomainDeviceDefAddress(const virDomainDeviceDef *dev,
     case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW:
         if (!qemuDomainIsS390CCW(def)) {
             virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
-                           _("cannot use CCW address type for device '%1$s' using machine type '%2$s'"),
-                           NULLSTR(info->alias), def->os.machine);
+                           _("CCW addresses are not supported by machine type '%1$s'"),
+                           def->os.machine);
             return -1;
         }