]> xenbits.xensource.com Git - unikraft/unikraft.git/commitdiff
drivers/virtio/blk: Remove unused warnings
authorMichalis Pappas <michalis@unikraft.io>
Mon, 25 Sep 2023 14:09:19 +0000 (16:09 +0200)
committerRazvan Deaconescu <razvand@unikraft.io>
Fri, 20 Oct 2023 16:35:55 +0000 (19:35 +0300)
When building without assertions some arguments and variables
are not used. This commit adds respective attributes to solve
the warning.

Signed-off-by: Marc Rittinghaus <marc.rittinghaus@kit.edu>
Reviewed-by: Michalis Pappas <michalis@unikraft.io>
Reviewed-by: Andrei Topala <topala.andrei@gmail.com>
Reviewed-by: Marco Schlumpp <marco@unikraft.io>
Approved-by: Razvan Deaconescu <razvand@unikraft.io>
GitHub-Closes: #1115

drivers/virtio/blk/virtio_blk.c

index d3e8b94da9f3c1e59f512ee43acbd4016639ef07..ef9ac0083613b05d6a27f3fcf7d6076d71148ff1 100644 (file)
@@ -334,16 +334,15 @@ out:
        return rc;
 }
 
-static int virtio_blkdev_submit_request(struct uk_blkdev *dev,
-               struct uk_blkdev_queue *queue,
-               struct uk_blkreq *req)
+static int virtio_blkdev_submit_request(struct uk_blkdev *dev __unused,
+                                       struct uk_blkdev_queue *queue,
+                                       struct uk_blkreq *req)
 {
        int rc = 0;
        int status = 0x0;
 
        UK_ASSERT(req);
        UK_ASSERT(queue);
-       UK_ASSERT(dev);
 
        rc = virtio_blkdev_queue_enqueue(queue, req);
        if (likely(rc >= 0)) {
@@ -405,14 +404,12 @@ out:
        return ret;
 }
 
-static int virtio_blkdev_complete_reqs(struct uk_blkdev *dev,
-               struct uk_blkdev_queue *queue)
+static int virtio_blkdev_complete_reqs(struct uk_blkdev *dev __unused,
+                                      struct uk_blkdev_queue *queue)
 {
        struct uk_blkreq *req;
        int rc = 0;
 
-       UK_ASSERT(dev);
-
        /* Queue interrupts have to be off when calling receive */
        UK_ASSERT(!(queue->intr_enabled & VTBLK_INTR_EN));
 
@@ -462,13 +459,11 @@ static int virtio_blkdev_recv_done(struct virtqueue *vq, void *priv)
        return 1;
 }
 
-static int virtio_blkdev_queue_intr_enable(struct uk_blkdev *dev,
-               struct uk_blkdev_queue *queue)
+static int virtio_blkdev_queue_intr_enable(struct uk_blkdev *dev __unused,
+                                          struct uk_blkdev_queue *queue)
 {
        int rc = 0;
 
-       UK_ASSERT(dev);
-
        /* If the interrupt is enabled */
        if (queue->intr_enabled & VTBLK_INTR_EN)
                return 0;
@@ -486,10 +481,9 @@ static int virtio_blkdev_queue_intr_enable(struct uk_blkdev *dev,
        return rc;
 }
 
-static int virtio_blkdev_queue_intr_disable(struct uk_blkdev *dev,
-               struct uk_blkdev_queue *queue)
+static int virtio_blkdev_queue_intr_disable(struct uk_blkdev *dev __unused,
+                                           struct uk_blkdev_queue *queue)
 {
-       UK_ASSERT(dev);
        UK_ASSERT(queue);
 
        virtqueue_intr_disable(queue->vq);