]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemuDomainSetBlockThreshold: Call qemuBlockNodeNamesDetect only without blockdev
authorPeter Krempa <pkrempa@redhat.com>
Tue, 5 May 2020 06:51:49 +0000 (08:51 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Tue, 12 May 2020 04:55:00 +0000 (06:55 +0200)
Make sure that we don't try to reload node names with -blockdev. If
something doesn't have a node name the update will not make the
situation better.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
src/qemu/qemu_driver.c

index c5e6cab8176fc92b826c56e09ddb2a3ec063d36e..cb0373bf76f48435832a0abaadad15987bd45e28 100644 (file)
@@ -22597,7 +22597,8 @@ qemuDomainSetBlockThreshold(virDomainPtr dom,
     if (!(src = qemuDomainGetStorageSourceByDevstr(dev, vm->def)))
         goto endjob;
 
-    if (!src->nodestorage &&
+    if (!virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_BLOCKDEV) &&
+        !src->nodestorage &&
         qemuBlockNodeNamesDetect(driver, vm, QEMU_ASYNC_JOB_NONE) < 0)
         goto endjob;