Executive DB retry: Avoid an undefined warning

If something other than the DB statements inside need_retry throws an
exception, ->err will normally be undef (because
$dbh_tests->begin_work will clear it, if nothing else).

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>

diff --git a/Osstest/JobDB/Executive.pm b/Osstest/JobDB/Executive.pm
index 6fb77a411267e9e730502a67f2baa9d0a835d53b..c0af21c457d91b94e6af3944bf832fa428ee7613 100644 (file)
--- a/Osstest/JobDB/Executive.pm
+++ b/Osstest/JobDB/Executive.pm
@@ -50,7 +50,7 @@ sub begin_work ($$$) { #method
 sub need_retry ($$$) {
     my ($jd, $dbh,$committing) = @_;
     return
-       $dbh_tests->err()==7 &&
+       ($dbh_tests->err() // 0)==7 &&
        ($dbh_tests->state =~ m/^40P01/); # DEADLOCK DETECTED
 }