]> xenbits.xensource.com Git - libvirt.git/commitdiff
xenconfig: fix issue found by coverity in multiple IP support
authorMarek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Wed, 13 Dec 2017 19:15:49 +0000 (20:15 +0100)
committerJohn Ferlan <jferlan@redhat.com>
Wed, 13 Dec 2017 20:31:55 +0000 (15:31 -0500)
virStringSplit may return NULL, so we must handle that.

Cc: John Ferlan <jferlan@redhat.com>
Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
src/xenconfig/xen_common.c

index 9777d23475443503256f7c28f011e6ec97542279..ca3b4dee6a9c06738f3fd22fe420aa7d4b38be05 100644 (file)
@@ -968,6 +968,9 @@ xenParseVif(virConfPtr conf, virDomainDefPtr def, const char *vif_typename)
                 char **ip_list = virStringSplit(ip, " ", 0);
                 size_t i;
 
+                if (!ip_list)
+                    goto cleanup;
+
                 for (i = 0; ip_list[i]; i++) {
                     if (virDomainNetAppendIPAddress(net, ip_list[i], 0, 0) < 0) {
                         virStringListFree(ip_list);