]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemuDomainRemoveDiskDevice: Remove special casing for disks on 'sd' bus
authorPeter Krempa <pkrempa@redhat.com>
Thu, 21 Jul 2022 12:39:01 +0000 (14:39 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Thu, 11 Aug 2022 13:22:22 +0000 (15:22 +0200)
SD card disks can't be detached, so it makes no sense to special case
them in the unplug code.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/qemu/qemu_hotplug.c

index e2d30d5873d35338603f1cd9b28c573730d04edf..ec7396189571dbecf3d379132543a7f409b3cc78 100644 (file)
@@ -4282,7 +4282,7 @@ qemuDomainRemoveDiskDevice(virQEMUDriver *driver,
 
         if (!(diskBackend = qemuBlockStorageSourceChainDetachPrepareChardev(chardevAlias)))
             goto cleanup;
-    } else if (blockdev && !qemuDiskBusIsSD(disk->bus)) {
+    } else if (blockdev) {
         if (diskPriv->blockjob) {
             /* the block job keeps reference to the disk chain */
             diskPriv->blockjob->disk = NULL;