]> xenbits.xensource.com Git - xen.git/commitdiff
xen: sched: use default scheduler upon an invalid "sched="
authorDario Faggioli <dario.faggioli@citrix.com>
Fri, 17 Jun 2016 10:31:00 +0000 (12:31 +0200)
committerGeorge Dunlap <george.dunlap@citrix.com>
Fri, 17 Jun 2016 14:08:08 +0000 (15:08 +0100)
instead of just the first scheduler we find in the array.

In fact, right now, if someone makes a typo when passing
the "sched=" command line option to Xen, we (with all
schedulers configured in) pick ARINC653, which is most
likely not what one would expect.

Go for the default scheduler instead.

Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
Acked-by: George Dunlap <george.dunlap@citrix.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-By: Jonathan Creekmore <jonathan.creekmore@gmail.com>
xen/common/schedule.c

index 5e35310411ee62c558ed37fd46827836d00ea21c..7ac12d3dfc922f554ae7b13edc31274b400cb883 100644 (file)
@@ -1625,7 +1625,8 @@ void __init scheduler_init(void)
     {
         printk("Could not find scheduler: %s\n", opt_sched);
         for ( i = 0; i < NUM_SCHEDULERS; i++ )
-            if ( schedulers[i] )
+            if ( schedulers[i] &&
+                 !strcmp(schedulers[i]->opt_name, CONFIG_SCHED_DEFAULT) )
             {
                 ops = *schedulers[i];
                 break;