]> xenbits.xensource.com Git - people/pauldu/xenvif.git/commitdiff
Squash buffer overlow error messages in transmit
authorPaul Durrant <paul.durrant@citrix.com>
Fri, 19 Dec 2014 11:59:05 +0000 (11:59 +0000)
committerPaul Durrant <paul.durrant@citrix.com>
Fri, 19 Dec 2014 12:03:15 +0000 (12:03 +0000)
Occasionally packets are too fragmented to fit into the maximum number of
requests allowed by the netif protocol. In this case the packet preparation
function will fail with STATUS_BUFFER_OVERFLOW and the alternative copy-
coalesce prepation function will be called. These error messages are
therefore un-interesting (since the number of packets directly granted vs.
those that were copied is available in the statistics dump initiated by the
debug VIRQ).
This patch squashes the error messages to avoid filling logs.

Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
src/xenvif/transmitter.c

index 8125a5acb794056e71abfbc9f76fa47322fcb6ac..29d17fa9d798d0465a9d5ae95f9934fffd5a9f94 100644 (file)
@@ -787,7 +787,8 @@ __TransmitterRingGrantPayload(
 
 fail3:
 fail2:
-    Error("fail2\n");
+    if (status != STATUS_BUFFER_OVERFLOW)
+        Error("fail2\n");
 
     if (Fragment != NULL) {
         ASSERT3P(Fragment->Context, ==, Packet);
@@ -800,7 +801,8 @@ fail2:
     }
 
 fail1:
-    Error("fail1 (%08x)\n", status);
+    if (status != STATUS_BUFFER_OVERFLOW)
+        Error("fail1 (%08x)\n", status);
 
     ASSERT3P(Fragment, ==, NULL);