]> xenbits.xensource.com Git - people/liuw/mini-os.git/commitdiff
minios: clear FB content since _xmalloc may return non-zeroed memory
authorKeir Fraser <keir.fraser@citrix.com>
Mon, 12 May 2008 09:10:45 +0000 (10:10 +0100)
committerKeir Fraser <keir.fraser@citrix.com>
Mon, 12 May 2008 09:10:45 +0000 (10:10 +0100)
(in debug mode, notably).

Signed-off-by: Samuel Thibault <samuel.thibault@eu.citrix.com>
kernel.c

index 662acb0b0082ae4c4bbbd15021d8b35d9f5ad7aa..ea92adca6abc854c90157004999407629704373f 100644 (file)
--- a/kernel.c
+++ b/kernel.c
@@ -303,13 +303,10 @@ static void fbfront_thread(void *p)
 
     memsize = n * PAGE_SIZE;
     fb = _xmalloc(memsize, PAGE_SIZE);
+    memset(fb, 0, memsize);
     mfns = xmalloc_array(unsigned long, n);
-    for (i = 0; i < n; i++) {
-        /* trigger CoW */
-        ((char *) fb) [i * PAGE_SIZE] = 0;
-        barrier();
+    for (i = 0; i < n; i++)
         mfns[i] = virtual_to_mfn((char *) fb + i * PAGE_SIZE);
-    }
     fb_dev = init_fbfront(NULL, mfns, WIDTH, HEIGHT, DEPTH, line_length, n);
     xfree(mfns);
     if (!fb_dev) {