]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemu_driver: Resolve Coverity CONSTANT_EXPRESSION_RESULT
authorJohn Ferlan <jferlan@redhat.com>
Wed, 27 Aug 2014 13:14:16 +0000 (09:14 -0400)
committerJohn Ferlan <jferlan@redhat.com>
Wed, 27 Aug 2014 16:52:27 +0000 (12:52 -0400)
The call to virDomainSnapshotRedefinePrep() had a spurrious ! in front of
it which caused Coverity to complan that the expression is always false.

src/qemu/qemu_driver.c

index 2db507f8292475939023b3cfe4de1c3e0b0cda75..73959dab4a10c7c7aea8ca8d97681f0a7ecfe86a 100644 (file)
@@ -13461,8 +13461,8 @@ qemuDomainSnapshotCreateXML(virDomainPtr domain,
     }
 
     if (redefine) {
-        if (!virDomainSnapshotRedefinePrep(domain, vm, &def, &snap,
-                                           &update_current, flags) < 0)
+        if (virDomainSnapshotRedefinePrep(domain, vm, &def, &snap,
+                                          &update_current, flags) < 0)
             goto cleanup;
     } else {
         /* Easiest way to clone inactive portion of vm->def is via