]> xenbits.xensource.com Git - libvirt.git/commitdiff
Produce more verbose error if cppi not found
authorMichal Privoznik <mprivozn@redhat.com>
Mon, 17 Jun 2019 16:19:03 +0000 (18:19 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Tue, 18 Jun 2019 06:55:03 +0000 (08:55 +0200)
It's fairly easy (especially for new contributors) to not spot
the 'cppi not installed' line in the syntax-check output. Add a
banner that is shown at the end of syntax-check output if no cppi
was found.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
ACKed-by: Andrea Bolognani <abologna@redhat.com>
cfg.mk

diff --git a/cfg.mk b/cfg.mk
index 5074ef611adb538c5801660c6aad843bcdda6557..c0c240b2c0bf240f8ea5ff07f235c8865be4982a 100644 (file)
--- a/cfg.mk
+++ b/cfg.mk
@@ -1145,6 +1145,11 @@ ifneq ($(_gl-Makefile),)
 syntax-check: spacing-check test-wrap-argv \
        prohibit-duplicate-header mock-noinline group-qemu-caps \
         header-ifdef
+       @if ! cppi --version >/dev/null 2>&1; then \
+               echo "*****************************************************" >&2; \
+               echo "* cppi not installed, some checks have been skipped *" >&2; \
+               echo "*****************************************************" >&2; \
+       fi
 endif
 
 # Don't include duplicate header in the source (either *.c or *.h)