]> xenbits.xensource.com Git - libvirt.git/commitdiff
virhostcpu: Expose virHostCPUGetOnline on non-Linux
authorMartin Kletzander <mkletzan@redhat.com>
Mon, 27 Mar 2017 14:16:43 +0000 (16:16 +0200)
committerMartin Kletzander <mkletzan@redhat.com>
Mon, 27 Mar 2017 15:34:59 +0000 (17:34 +0200)
Previously, this function must've been called only on Linux in order
to fail gracefully.  That lead to #ifdef mess in callers, so the
function was redesigned so it failed gracefully on non-existing
files.  However that commit forgot to define the function outside the
__linux__ ifdef, it broke non-Linux builds.

Caused by c67e04e25fa58104e0fae41f5b874a8067557073.

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
src/util/virhostcpu.c

index 47f930cdbf3cac96493693fd42b0c9f6d3b915dc..02b9fc8eb94f1ac95f58b18d1a01725c3abd3de7 100644 (file)
@@ -262,24 +262,6 @@ virHostCPUGetCore(unsigned int cpu, unsigned int *core)
     return 0;
 }
 
-int
-virHostCPUGetOnline(unsigned int cpu, bool *online)
-{
-    unsigned int tmp = 0;
-    int ret = virSysfsGetCpuValueUint(cpu, "online", &tmp);
-
-
-    /* If the file is not there, it's online (doesn't support offlining) */
-    if (ret == -2)
-        tmp = 1;
-    else if (ret < 0)
-        return -1;
-
-    *online = tmp;
-
-    return 0;
-}
-
 virBitmapPtr
 virHostCPUGetSiblingsList(unsigned int cpu)
 {
@@ -880,6 +862,23 @@ virHostCPUParseCountLinux(void)
 }
 #endif
 
+int
+virHostCPUGetOnline(unsigned int cpu, bool *online)
+{
+    unsigned int tmp = 0;
+    int ret = virSysfsGetCpuValueUint(cpu, "online", &tmp);
+
+
+    /* If the file is not there, it's online (doesn't support offlining) */
+    if (ret == -2)
+        tmp = 1;
+    else if (ret < 0)
+        return -1;
+
+    *online = tmp;
+
+    return 0;
+}
 
 int
 virHostCPUStatsAssign(virNodeCPUStatsPtr param,