]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemu: Properly release job in qemuDomainSaveInternal
authorJiri Denemark <jdenemar@redhat.com>
Wed, 27 Jul 2022 13:40:12 +0000 (15:40 +0200)
committerJiri Denemark <jdenemar@redhat.com>
Wed, 27 Jul 2022 14:22:29 +0000 (16:22 +0200)
The function would fail to release the job in case
qemuMigrationSrcIsAllowed failed.

Fixes v8.5.0-157-g69e0e33873

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
src/qemu/qemu_driver.c

index 9013e6fb8d9af262077934bbdd66398c0c6b1dfe..019ec4a0359ca7e727c90809430887b060dffe1d 100644 (file)
@@ -2656,7 +2656,7 @@ qemuDomainSaveInternal(virQEMUDriver *driver,
         goto cleanup;
 
     if (!qemuMigrationSrcIsAllowed(driver, vm, false, VIR_ASYNC_JOB_SAVE, 0))
-        goto cleanup;
+        goto endjob;
 
     if (!virDomainObjIsActive(vm)) {
         virReportError(VIR_ERR_INTERNAL_ERROR, "%s",