]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemuFDPassValidate: Don't validate file descriptors
authorPeter Krempa <pkrempa@redhat.com>
Tue, 17 May 2022 08:32:47 +0000 (10:32 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Tue, 17 May 2022 17:31:08 +0000 (19:31 +0200)
The callers adding the FDs are validating them regardless so this check
was redundant.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/qemu/qemu_fd.c

index baa16fd669769c9a178b10aa4555a4d70f3c1360..3b4c0690803af5c6f64f38c80fbe4f4d7b57cbc7 100644 (file)
@@ -68,8 +68,6 @@ qemuFDPassFree(qemuFDPass *fdpass)
 static int
 qemuFDPassValidate(qemuFDPass *fdpass)
 {
-    size_t i;
-
     if (!fdpass->useFDSet &&
         fdpass->nfds > 1) {
         virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
@@ -77,14 +75,6 @@ qemuFDPassValidate(qemuFDPass *fdpass)
         return -1;
     }
 
-    for (i = 0; i < fdpass->nfds; i++) {
-        if (fdpass->fds[i].fd < 0) {
-            virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
-                           _("invalid file descriptor"));
-            return -1;
-        }
-    }
-
     return 0;
 }