]> xenbits.xensource.com Git - qemu-xen.git/commitdiff
virtiofsd: do_read missing NULL check
authorDr. David Alan Gilbert <dgilbert@redhat.com>
Mon, 3 Feb 2020 13:01:19 +0000 (13:01 +0000)
committerDr. David Alan Gilbert <dgilbert@redhat.com>
Mon, 10 Feb 2020 17:24:43 +0000 (17:24 +0000)
Missing a NULL check if the argument fetch fails.

Fixes: Coverity CID 1413119
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
tools/virtiofsd/fuse_lowlevel.c

index 01c418aade3c005e86ce29baf44862c383e0a7e0..704c0369b2a822ac7a3f082ecb4301ab42a02062 100644 (file)
@@ -1116,6 +1116,10 @@ static void do_read(fuse_req_t req, fuse_ino_t nodeid,
         struct fuse_file_info fi;
 
         arg = fuse_mbuf_iter_advance(iter, sizeof(*arg));
+        if (!arg) {
+            fuse_reply_err(req, EINVAL);
+            return;
+        }
 
         memset(&fi, 0, sizeof(fi));
         fi.fh = arg->fh;