]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemu: domain: Fix logic bug in qemuDomainStorageSourceAccessAllow
authorPeter Krempa <pkrempa@redhat.com>
Tue, 11 Jun 2019 13:16:09 +0000 (15:16 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Wed, 12 Jun 2019 07:40:02 +0000 (09:40 +0200)
In commit 76b9aba2ba6 I tried to refactor qemuDomainStorageSourceAccessAllow
but used wrong operators for adding bitwise flags.

This way the flags would result in 0 if any of them would be applied.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/qemu/qemu_domain.c

index 4d3a8868b235f38cc21bda191fe9f80b94792d49..e521bd3982096f0bc14f4b582d40353d3530ffcd 100644 (file)
@@ -9491,10 +9491,10 @@ qemuDomainStorageSourceAccessAllow(virQEMUDriverPtr driver,
     qemuDomainStorageSourceAccessFlags flags = QEMU_DOMAIN_STORAGE_SOURCE_ACCESS_SKIP_REVOKE;
 
     if (readonly)
-        flags &= QEMU_DOMAIN_STORAGE_SOURCE_ACCESS_READ_ONLY;
+        flags |= QEMU_DOMAIN_STORAGE_SOURCE_ACCESS_READ_ONLY;
 
     if (!newSource)
-        flags &= QEMU_DOMAIN_STORAGE_SOURCE_ACCESS_MODIFY_ACCESS;
+        flags |= QEMU_DOMAIN_STORAGE_SOURCE_ACCESS_MODIFY_ACCESS;
 
     return qemuDomainStorageSourceAccessModify(driver, vm, elem, flags);
 }