]> xenbits.xensource.com Git - libvirt.git/commitdiff
libxl: disable VNC and SDL until explicitly enabled
authorMarek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Tue, 10 Feb 2015 02:36:47 +0000 (03:36 +0100)
committerJim Fehlig <jfehlig@suse.com>
Thu, 12 Feb 2015 03:24:20 +0000 (20:24 -0700)
When initializing a libxl_domain_build_info struct with
libxl_domain_build_info_init(), VNC is enabled by default.  As a
result, VMs configured with no graphics still have VNC enabled.
This behavior is a regression wrt to the legacy Xen driver.

Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
src/libxl/libxl_conf.c

index 4489f84695c5db67da3420adf2ae89834da0c135..e092b11df5a9f3da54859e4c9f1346650fcd2569 100644 (file)
@@ -745,6 +745,10 @@ libxlMakeDomBuildInfo(virDomainDefPtr def,
             return -1;
         }
 
+        /* Disable VNC and SDL until explicitly enabled */
+        libxl_defbool_set(&b_info->u.hvm.vnc.enable, 0);
+        libxl_defbool_set(&b_info->u.hvm.sdl.enable, 0);
+
         /*
          * The following comment and calculation were taken directly from
          * libxenlight's internal function libxl_get_required_shadow_memory():