]> xenbits.xensource.com Git - people/iwj/osstest.git/commitdiff
sg-report-flight: move "started" column to the left in Step table
authorIan Campbell <ian.campbell@citrix.com>
Fri, 19 Feb 2016 16:21:44 +0000 (16:21 +0000)
committerIan Jackson <Ian.Jackson@eu.citrix.com>
Fri, 18 Mar 2016 17:06:07 +0000 (17:06 +0000)
With the current ordering of status => started I frequently (more
often than not) read the failing step as "(stepno,testid,script)
failed at <time>" (where <time> is actually the start time, not the
fail time).

Move the "started" column to the left of the "status" column. On the
basis that "(stepno,testid,script) started at $time and failed" reads
more (chrono)logically.

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
sg-report-flight

index db0d9220e7f07c6444758d896228e8e1dc4b84d3..99bde92b74c754c458b7e45da43189acac4c8160 100755 (executable)
@@ -954,8 +954,8 @@ END
 </ul>
 <h2>Steps</h2>
 <table rules=all>
-<tr><th>stepno</th><th>testid</th><th>script</th><th>status</th>
-<th>started</th><th>duration</th></tr>
+<tr><th>stepno</th><th>testid</th><th>script</th><th>started</th>
+<th>status</th><th>duration</th></tr>
 END
 
     my %issteplog;
@@ -977,6 +977,8 @@ END
         $stepcol->('testid', '');
         $stepcol->('step', '');
 
+        printf H "<td>%s</td>", show_abs_time $step->{started};
+
         my $st= $step->{status};
         my $logfilename= "$step->{stepno}.$step->{step}.log";
         printf H "<td bgcolor='%s'><a href='%s'>%s</a></td>",
@@ -985,8 +987,6 @@ END
             encode_entities($st);
         $issteplog{$logfilename}= 1;
 
-        printf H "<td>%s</td>", show_abs_time $step->{started};
-
        if (defined $step->{finished} && defined $step->{started}) {
            printf H "<td align=right>%d</td>\n",
                 $step->{finished} - $step->{started};