]> xenbits.xensource.com Git - libvirt.git/commitdiff
xenapi: Drop check for auth
authorMarcos Paulo de Souza <marcos.souza.org@gmail.com>
Fri, 3 Aug 2018 00:27:55 +0000 (21:27 -0300)
committerMichal Privoznik <mprivozn@redhat.com>
Tue, 14 Aug 2018 14:16:31 +0000 (16:16 +0200)
Since they are done inside virAuthGetPassword and virAuthGetUsername
when needed. Also, only auth is checked, but auth->cb, which that could
lead to a crash if the callback is NULL.

Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
src/xenapi/xenapi_driver.c

index 34f9e2c717b66069f0cbd45c44d8904818618fd9..3af5eeafcfd6dd90ab8c4c1eaf0c95ee300cc39b 100644 (file)
@@ -152,12 +152,6 @@ xenapiConnectOpen(virConnectPtr conn, virConnectAuthPtr auth,
         goto error;
     }
 
-    if (auth == NULL) {
-        xenapiSessionErrorHandler(conn, VIR_ERR_AUTH_FAILED,
-                                  _("Authentication Credentials not found"));
-        goto error;
-    }
-
     if (conn->uri->user != NULL) {
         if (VIR_STRDUP(username, conn->uri->user) < 0)
             goto error;