]> xenbits.xensource.com Git - libvirt.git/commitdiff
virDomainInterfaceAddresses: Allow API on RO connection too
authorMichal Privoznik <mprivozn@redhat.com>
Mon, 11 Jan 2016 11:48:30 +0000 (12:48 +0100)
committerMichal Privoznik <mprivozn@redhat.com>
Mon, 11 Jan 2016 12:36:19 +0000 (13:36 +0100)
This API does not change domain state. However, we have a policy
that an API talking to a guest agent requires RW access. But that
happens only if source == VIR_DOMAIN_INTERFACE_ADDRESSES_SRC_AGENT.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
src/libvirt-domain.c

index 677a9ad8de6fb6b12ac35abd2b56c9102f84a4d7..02fc4df45d10c4d35679317abfcbc08e0040b203 100644 (file)
@@ -11546,7 +11546,8 @@ virDomainInterfaceAddresses(virDomainPtr dom,
         *ifaces = NULL;
     virCheckDomainReturn(dom, -1);
     virCheckNonNullArgGoto(ifaces, error);
-    virCheckReadOnlyGoto(dom->conn->flags, error);
+    if (source == VIR_DOMAIN_INTERFACE_ADDRESSES_SRC_AGENT)
+        virCheckReadOnlyGoto(dom->conn->flags, error);
 
     if (dom->conn->driver->domainInterfaceAddresses) {
         int ret;