]> xenbits.xensource.com Git - libvirt.git/commitdiff
vmware: Properly clean up in vmwareDomainLookupByName
authorJohn Ferlan <jferlan@redhat.com>
Fri, 9 Mar 2018 14:48:07 +0000 (09:48 -0500)
committerJohn Ferlan <jferlan@redhat.com>
Fri, 20 Apr 2018 11:50:24 +0000 (07:50 -0400)
The virDomainObjListFindByName returns a locked and reffed
domain object, all we did was unlock it, leaving an extra
ref. Use the virDomainObjEndAPI to cleanup instead.

Signed-off-by: John Ferlan <jferlan@redhat.com>
Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
src/vmware/vmware_driver.c

index b4b809f1a8ae739476e8bd898317c9db84885924..783496f4de13067f59cdbfc1fc594c4e307cd5fb 100644 (file)
@@ -922,8 +922,7 @@ vmwareDomainLookupByName(virConnectPtr conn, const char *name)
     dom = virGetDomain(conn, vm->def->name, vm->def->uuid, vm->def->id);
 
  cleanup:
-    if (vm)
-        virObjectUnlock(vm);
+    virDomainObjEndAPI(&vm);
     return dom;
 }