]> xenbits.xensource.com Git - libvirt.git/commitdiff
libxl: Fix memory leak if pthread_create fails.
authorKonrad Rzeszutek Wilk <konrad@kernel.org>
Thu, 26 Mar 2015 01:35:11 +0000 (21:35 -0400)
committerJim Fehlig <jfehlig@suse.com>
Thu, 26 Mar 2015 20:22:36 +0000 (14:22 -0600)
If we fail to create the thread we leak the shutdown_info
structure.

Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
src/libxl/libxl_domain.c

index 8feb4dc627ac41e250c5bac67f60fe08172f7128..ce9e4d8f39b7c679471dc41408f62d72b4617c0a 100644 (file)
@@ -473,7 +473,7 @@ libxlDomainEventHandler(void *data, VIR_LIBXL_EVENT_CONST libxl_event *event)
     libxlDriverPrivatePtr driver = data;
     virDomainObjPtr vm = NULL;
     libxl_shutdown_reason xl_reason = event->u.domain_shutdown.shutdown_reason;
-    struct libxlShutdownThreadInfo *shutdown_info;
+    struct libxlShutdownThreadInfo *shutdown_info = NULL;
     virThread thread;
     libxlDriverConfigPtr cfg;
 
@@ -526,6 +526,7 @@ libxlDomainEventHandler(void *data, VIR_LIBXL_EVENT_CONST libxl_event *event)
     virObjectUnref(cfg);
     if (vm)
         virObjectUnlock(vm);
+    VIR_FREE(shutdown_info);
 }
 
 void