]> xenbits.xensource.com Git - libvirt.git/commitdiff
remoteDispatchDomainMigratePrepare*: Don't pass uninitialized variable to VIR_FREE
authorPeter Krempa <pkrempa@redhat.com>
Thu, 11 Jun 2020 08:34:21 +0000 (10:34 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Mon, 15 Jun 2020 08:27:37 +0000 (10:27 +0200)
'uri_out' may be passed to VIR_FREE uninitialized if 'conn' is NULL.
Unfortunately the compiler isn't able to detect this problem when
VIR_FREE is implemented using g_clear_pointer. Initialize the variable.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com
src/remote/remote_daemon_dispatch.c

index 6f67d2fb30166d8b94bf0be41934e6dac471e7e2..831e7d165cf7e828628cc0093b76380772ba538c 100644 (file)
@@ -3030,7 +3030,7 @@ remoteDispatchDomainMigratePrepare(virNetServerPtr server G_GNUC_UNUSED,
     char *cookie = NULL;
     int cookielen = 0;
     char *uri_in;
-    char **uri_out;
+    char **uri_out = NULL;
     char *dname;
     int rv = -1;
     virConnectPtr conn = remoteGetHypervisorConn(client);
@@ -3082,7 +3082,7 @@ remoteDispatchDomainMigratePrepare2(virNetServerPtr server G_GNUC_UNUSED,
     char *cookie = NULL;
     int cookielen = 0;
     char *uri_in;
-    char **uri_out;
+    char **uri_out = NULL;
     char *dname;
     int rv = -1;
     virConnectPtr conn = remoteGetHypervisorConn(client);
@@ -4789,7 +4789,7 @@ remoteDispatchDomainMigratePrepare3(virNetServerPtr server G_GNUC_UNUSED,
     char *cookieout = NULL;
     int cookieoutlen = 0;
     char *uri_in;
-    char **uri_out;
+    char **uri_out = NULL;
     char *dname;
     int rv = -1;
     virConnectPtr conn = remoteGetHypervisorConn(client);
@@ -5584,7 +5584,7 @@ remoteDispatchDomainMigratePrepare3Params(virNetServerPtr server G_GNUC_UNUSED,
     int nparams = 0;
     char *cookieout = NULL;
     int cookieoutlen = 0;
-    char **uri_out;
+    char **uri_out = NULL;
     int rv = -1;
     virConnectPtr conn = remoteGetHypervisorConn(client);