]> xenbits.xensource.com Git - xen.git/commitdiff
ns16550: properly gate Exar PCIe UART cards support
authorOleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Fri, 20 Aug 2021 14:18:12 +0000 (16:18 +0200)
committerJan Beulich <jbeulich@suse.com>
Fri, 20 Aug 2021 14:18:12 +0000 (16:18 +0200)
Arm is about to get PCI passthrough support which means CONFIG_HAS_PCI
will be enabled, so this code will fail as Arm doesn't have ns16550
PCI support:

ns16550.c:313:5: error: implicit declaration of function 'enable_exar_enhanced_bits' [-Werror=implicit-function-declaration]
  313 |     enable_exar_enhanced_bits(uart);
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~

Fix this by gating Exar PCIe UART cards support with the above in mind.

Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
xen/drivers/char/ns16550.c

index b777c8711ee0944c85072989c082276bf8778734..e2c24082c368110cce5f93c43a81cdd096fbf7cf 100644 (file)
@@ -308,7 +308,7 @@ static void ns16550_setup_preirq(struct ns16550 *uart)
     /* Handle the DesignWare 8250 'busy-detect' quirk. */
     handle_dw_usr_busy_quirk(uart);
 
-#ifdef CONFIG_HAS_PCI
+#ifdef NS16550_PCI
     /* Enable Exar "Enhanced function bits" */
     enable_exar_enhanced_bits(uart);
 #endif