]> xenbits.xensource.com Git - libvirt.git/commitdiff
Improve error message diagnosing incorrect XML CPU mode
authorDaniel P. Berrange <berrange@redhat.com>
Wed, 13 Jun 2012 17:21:29 +0000 (18:21 +0100)
committerDaniel P. Berrange <berrange@redhat.com>
Thu, 14 Jun 2012 16:01:24 +0000 (17:01 +0100)
Tell the user what CPU mode value is wrong

src/conf/cpu_conf.c

index 018d57170e3fe7424be41ec00ecba65d4dcb7999..b520f7c6417cf2d1ad7e02651e806cbf70dd72f6 100644 (file)
@@ -234,13 +234,15 @@ virCPUDefParseXML(const xmlNodePtr node,
             goto error;
         } else {
             def->mode = virCPUModeTypeFromString(cpuMode);
-            VIR_FREE(cpuMode);
 
             if (def->mode < 0) {
-                virCPUReportError(VIR_ERR_INTERNAL_ERROR, "%s",
-                                  _("Invalid mode attribute"));
+                virCPUReportError(VIR_ERR_INTERNAL_ERROR,
+                                  _("Invalid mode attribute '%s'"),
+                                  cpuMode);
+                VIR_FREE(cpuMode);
                 goto error;
             }
+            VIR_FREE(cpuMode);
         }
     } else {
         if (def->type == VIR_CPU_TYPE_HOST)