]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemu: End job even if exiting monitor after OpenGraphics(FD) fails
authorLuyao Huang <lhuang@redhat.com>
Tue, 30 Jun 2015 03:35:13 +0000 (11:35 +0800)
committerMartin Kletzander <mkletzan@redhat.com>
Wed, 1 Jul 2015 06:36:48 +0000 (08:36 +0200)
Signed-off-by: Luyao Huang <lhuang@redhat.com>
src/qemu/qemu_driver.c

index 3c8ccd21f68f97a2991fa8721b01aa540d56e15f..1a2f8a27a9f7f2b5535d53a168de064f2d06ea5e 100644 (file)
@@ -17265,10 +17265,8 @@ qemuDomainOpenGraphics(virDomainPtr dom,
     qemuDomainObjEnterMonitor(driver, vm);
     ret = qemuMonitorOpenGraphics(priv->mon, protocol, fd, "graphicsfd",
                                   (flags & VIR_DOMAIN_OPEN_GRAPHICS_SKIPAUTH) != 0);
-    if (qemuDomainObjExitMonitor(driver, vm) < 0) {
+    if (qemuDomainObjExitMonitor(driver, vm) < 0)
         ret = -1;
-        goto cleanup;
-    }
     qemuDomainObjEndJob(driver, vm);
 
  cleanup:
@@ -17337,10 +17335,8 @@ qemuDomainOpenGraphicsFD(virDomainPtr dom,
     qemuDomainObjEnterMonitor(driver, vm);
     ret = qemuMonitorOpenGraphics(priv->mon, protocol, pair[1], "graphicsfd",
                                   (flags & VIR_DOMAIN_OPEN_GRAPHICS_SKIPAUTH));
-    if (qemuDomainObjExitMonitor(driver, vm) < 0) {
+    if (qemuDomainObjExitMonitor(driver, vm) < 0)
         ret = -1;
-        goto cleanup;
-    }
     qemuDomainObjEndJob(driver, vm);
     if (ret < 0)
         goto cleanup;